-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search UI/UX revamp #3941
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SychO9
added
type/feature
type/cleanup
prio/high
javascript
Pull requests that update Javascript code
type/i18n
needs-documentation
labels
Dec 1, 2023
imorland
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the roadmap
Changes proposed in this pull request:
This pull request implements the design work made by @iamdarkle (https://discuss.flarum.org/d/33443-flarum-20-uiux-improvements-for-enhanced-search-experience/) to improve the searching experience.
The obvious visual changes include:
Some key technical changes/additions are:
AutocompleteReader
, we use this here for the gambit autocompletion.GambitsAutocomplete
utility which makes use of theAutocompleteReader
.GambitsAutocompleteDropdown
used for independent inputs (like the admin users page), unrelated to the SearchModal.BooleanGambit
andKeyValueGambit
classes have been added to reduce the boilerplate of implementing gambits..yml
files)Screenshot
screen-capture (19).webm
Necessity
Confirmed
composer test
).