Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clear search button height issue #3937

Closed
wants to merge 1 commit into from
Closed

Fix clear search button height issue #3937

wants to merge 1 commit into from

Conversation

datlechin
Copy link
Contributor

Before:

Screenshot 2023-11-25 at 23 40 09

After: (by adding height: 100% to .Search-input .Button)

Screenshot 2023-11-25 at 23 40 21
Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner November 25, 2023 16:41
SychO9
SychO9 reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I checked and I believe this was added in the search UI/UX PR.

Please feel free to re-open if that wasn't the case.

@SychO9 SychO9 closed this Jan 19, 2024
@datlechin datlechin deleted the dat/fix-seach-clear-icon-height branch January 19, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@datlechin @SychO9