Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): use cookie for testing authentication #3924

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 5, 2023

Fixes #3834

Changes proposed in this pull request:

  • The authenticatedAs testing option makes use of an authorization header to authenticate the user, this only works on the api frontend, for forum or admin frontends we've always had to make a normal identification/password request to the login endpoint and use the generated cookie to run our tests. This isn't ideal.
  • This PR changed the autheticatedAs option to rely on a remember cookie by default. Which makes testing easier.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 5, 2023 15:23
@SychO9 SychO9 added this to the 2.0 milestone Nov 5, 2023
@SychO9 SychO9 self-assigned this Nov 5, 2023
@imorland imorland merged commit 693bce9 into 2.x Nov 10, 2023
22 checks passed
@imorland imorland deleted the sm/3834-use-cookie-for-testing-auth branch November 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

authenticatedAs option does not work with /admin routes in integration tests
2 participants