New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: load event mentioned tags on show discussion endpoint #3915

Merged

imorland merged 1 commit into 2.x from sm/discussion-tagged-event

Nov 1, 2023

Member

SychO9 commented Oct 29, 2023

Fixes #3863

Necessity

Has the problem that is being solved here been clearly explained?
If applicable, have various options for solving this problem been considered?
For core PRs, does this need to be in core, or could it be in an extension?
Are we willing to maintain this for years / potentially forever?

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).
Core developer confirmed locally this works as intended.
Tests have been added, or are not appropriate here.


          fix: load event mentioned tags on show discussion endpoint

33d5662

SychO9 requested a review from a team as a code owner

October 29, 2023 13:42

imorland approved these changes

View reviewed changes

imorland merged commit 5cdfa0f into 2.x

22 checks passed

imorland deleted the sm/discussion-tagged-event branch

November 1, 2023 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet