chore: improve debugging experience

flarum · Dec 13, 2023 · a715b3b · a715b3b
1 parent b4a82e8
commit a715b3b
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/framework/core/js/src/common/Application.tsx b/framework/core/js/src/common/Application.tsx
@@ -604,7 +604,9 @@ export default class Application {
         console.groupEnd();
       }
 
-      if (e.alert) {
+      if (e.status === 500 && isDebug) {
+        app.modal.show(RequestErrorModal, { error: e, formattedError: formattedErrors });
+      } else if (e.alert) {
         this.requestErrorAlert = this.alerts.show(e.alert, e.alert.content);
       }
     } else {

diff --git a/framework/core/js/src/common/components/RequestErrorModal.tsx b/framework/core/js/src/common/components/RequestErrorModal.tsx
@@ -30,6 +30,19 @@ export default class RequestErrorModal<CustomAttrs extends IRequestErrorModalAtt
       responseText = error.responseText;
     }
 
+    if (responseText?.includes('<script> Sfdump = window.Sfdump')) {
+      responseText = (
+        <iframe
+          srcdoc={responseText}
+          className="RequestErrorModal-iframe"
+          onload={(e: Event) => {
+            const iframe = e.target as HTMLIFrameElement;
+            iframe.style.height = (iframe.contentWindow?.document.body.offsetHeight || 0) + 50 + 'px';
+          }}
+        />
+      );
+    }
+
     return (
       <div className="Modal-body">
         <pre>

diff --git a/framework/core/less/common/scaffolding.less b/framework/core/less/common/scaffolding.less
@@ -137,6 +137,12 @@ blockquote ol:last-child {
     white-space: pre-wrap;
     margin: 0;
   }
+
+  &-iframe {
+    width: 100%;
+    max-height: 90vh;
+    border: 0;
+  }
 }
 
 #flarum-loading {