Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

videos are not downloading? #14

Closed
harisEshaafi opened this issue Nov 24, 2023 · 4 comments · Fixed by #15
Closed

videos are not downloading? #14

harisEshaafi opened this issue Nov 24, 2023 · 4 comments · Fixed by #15
Labels
bug Something isn't working High Priority

Comments

@harisEshaafi
Copy link

harisEshaafi commented Nov 24, 2023

Tiktok videos are not downloading now whats the issue

@fknives
Copy link
Owner

fknives commented Nov 24, 2023

Hey, thanks for the interest. As of now the App on my phone still downloads videos.
One thing I noticed however is that if a video was removed from TikTok downloading it will always fail and thus the next video won't be started.
To check this you can click on the Link in the Downloader app.
If it is indeed the case, you can swipe away the video from the queue.
Otherwise you might also try reordering the video queue by long tapping a card and moving it up or down.

I am planning to do an update which communicates these better.
I hope this helps

@fknives
Copy link
Owner

fknives commented Dec 14, 2023

Hmm, clearly existing videos started to fail to download for me too. I will look into it and will create a release

fknives added a commit that referenced this issue Dec 14, 2023
Attempt to get the video URL from the first response if the 'actual' url cannot be found within.

#14
@fknives fknives mentioned this issue Dec 14, 2023
fknives added a commit that referenced this issue Dec 14, 2023
@fknives
Copy link
Owner

fknives commented Dec 14, 2023

Hmm, the problem is not fully fixed by the PR.
It fixed one, but looks like sometimes the link throws the user to the login page, I should fix that also if I can. I imagine it is something like captcha.

I think the easiest resolution for that is to:

  • Recognize this state
  • Show an option to the user for authenticating the downloader app (There is a QR code option which could be used to link directly back to the app)
  • Store the auth token and use in subsequent requests.

Unknowns:

  • What token needs to be stored and sent
  • How to get that token in the first place
  • What happens if the token expires, does the same webpage shows or it is a separate issue?
  • How to have a test for this case without exposing my own account? Could I create a test account for this reason with secrets?

@fknives fknives reopened this Dec 14, 2023
@fknives fknives added bug Something isn't working High Priority labels Dec 14, 2023
@fknives
Copy link
Owner

fknives commented Dec 22, 2023

NVM I was tried and used the wrong build, #15 fixed the original issue.
The potential issue with videos requiring login bill be tracked #22 and closing this with 1.3.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants