Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unhelpful calls to sys.exit(1) #1322

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

maringuu
Copy link
Collaborator

The ImportError gives way more insight than just exiting.

The ImportError gives way more insight than just exiting.
@maringuu maringuu requested a review from jstucke December 18, 2024 10:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (058e49f) to head (296473f).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1322      +/-   ##
==========================================
- Coverage   92.42%   91.87%   -0.56%     
==========================================
  Files         379      378       -1     
  Lines       23661    20991    -2670     
==========================================
- Hits        21869    19285    -2584     
+ Misses       1792     1706      -86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jstucke jstucke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jstucke jstucke merged commit 5890119 into fkie-cad:master Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants