Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional dark mode fixes #1313

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

additional dark mode fixes #1313

wants to merge 3 commits into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Dec 10, 2024

  • dependency graph
    • fix node text color in dependency graph for dark mode
    • some jshint fixes
    • moved the dark mode JavaScript code into its own file (so it can also be used in dependency_graph.js)
  • GraphQL search
    • fixed <pre> elements for dark mode

@jstucke jstucke self-assigned this Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.84%. Comparing base (ad4d6d8) to head (a802b85).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
- Coverage   92.23%   91.84%   -0.39%     
==========================================
  Files         379      378       -1     
  Lines       23188    20981    -2207     
==========================================
- Hits        21387    19271    -2116     
+ Misses       1801     1710      -91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstucke jstucke marked this pull request as ready for review December 10, 2024 17:00
@jstucke jstucke changed the title fix: dark mode fix for dependency graph node text color additional dark mode fixes Dec 11, 2024
and replace the color values with the ones from the appropriate dark theme
@maringuu
Copy link
Collaborator

The Browse button on the upload also does not change color as opposed to the other buttons.

@jstucke
Copy link
Collaborator Author

jstucke commented Dec 19, 2024

The Browse button on the upload also does not change color as opposed to the other buttons.

Yes, I know. But sadly I was unable to fix this, as this is some internal Bootstrap black magic thing that does not seem to be addressable with CSS. Feel free to try, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants