Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test speedup #1298

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Test speedup #1298

merged 4 commits into from
Dec 19, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 14, 2024

No description provided.

@jstucke jstucke requested a review from maringuu November 14, 2024 16:34
@jstucke jstucke self-assigned this Nov 14, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.35%. Comparing base (bd5bdb0) to head (782b922).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
src/test/common_helper.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1298      +/-   ##
==========================================
+ Coverage   92.21%   92.35%   +0.13%     
==========================================
  Files         377      378       +1     
  Lines       23068    22113     -955     
==========================================
- Hits        21273    20423     -850     
+ Misses       1795     1690     -105     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

in a test run this reduced the total runtime for all tests by nearly 10%
…variable

and changed its default value for the tests to 0.2 for a significant teardown speedup
Copy link
Collaborator

@euwint euwint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@maringuu maringuu merged commit 37f66c7 into master Dec 19, 2024
10 checks passed
@maringuu maringuu deleted the test-speedup branch December 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants