Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify db connection constructor #1297

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 13, 2024

  • removed unnecessary user/pw parameters from db connection constructor

resolves #1035

@jstucke jstucke requested a review from maringuu November 13, 2024 15:49
@jstucke jstucke self-assigned this Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (58fe736) to head (2e073d7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1297      +/-   ##
==========================================
- Coverage   92.25%   91.87%   -0.39%     
==========================================
  Files         376      376              
  Lines       22054    21071     -983     
==========================================
- Hits        20346    19359     -987     
- Misses       1708     1712       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstucke jstucke force-pushed the simplify-db-connection-constructor branch from 2e073d7 to fb6137d Compare November 14, 2024 08:38
@maringuu maringuu merged commit 595175c into master Nov 14, 2024
10 checks passed
@maringuu maringuu deleted the simplify-db-connection-constructor branch November 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove user argument from ReadOnlyConnection constructor
3 participants