Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced test config files with default config #1296

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Nov 13, 2024

  • replaced test config files with default config
    • this fixes the problem that these config files always need to be updated as well if the default config changes
    • additional advantage: the default config is tested and the tests make sure that it is valid

resolves #1036

@jstucke jstucke changed the title chore: replaced test config files with default config replaced test config files with default config Nov 13, 2024
this fixes the problem that these config files always need to be updated as well if the default config changes

and there is one additional advantage: the default config is tested and the tests make sure that it is valid
@jstucke jstucke self-assigned this Nov 13, 2024
@jstucke jstucke requested a review from maringuu November 13, 2024 15:18
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.87%. Comparing base (58fe736) to head (3c93be6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   92.25%   91.87%   -0.38%     
==========================================
  Files         376      376              
  Lines       22054    21080     -974     
==========================================
- Hits        20346    19368     -978     
- Misses       1708     1712       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maringuu maringuu merged commit 56ba201 into master Nov 14, 2024
10 checks passed
@maringuu maringuu deleted the remove-test-config branch November 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: Test default configuration
3 participants