Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

converted IP&URI plugin to new base class #1288

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 29, 2024

No description provided.

@jstucke jstucke requested a review from maringuu October 29, 2024 15:59
@jstucke jstucke self-assigned this Oct 29, 2024
Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing, otherwise lgtm.

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 96.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.90%. Comparing base (86a6b3f) to head (dda840c).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/statistic/update.py 0.00% 2 Missing ⚠️
...alysis/ip_and_uri_finder/code/ip_and_uri_finder.py 97.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1288      +/-   ##
==========================================
- Coverage   91.94%   91.90%   -0.05%     
==========================================
  Files         377      376       -1     
  Lines       22295    21020    -1275     
==========================================
- Hits        20499    19318    -1181     
+ Misses       1796     1702      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maringuu maringuu self-requested a review November 27, 2024 15:25
@maringuu maringuu merged commit 4b87ffa into master Nov 27, 2024
10 checks passed
@maringuu maringuu deleted the ip-uri-plugin-v1 branch November 27, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants