sped up highlighting on analysis page #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Oct 25, 2024
jstucke
commented
- sped up highlighting on analysis page
- optimized code
- replaced custom line numbering function with much faster library
- don't highlight if the block is too large (>1MiB)
jstucke
force-pushed
the
highlighting-speedup
branch
2 times, most recently
from
257dfb3 to
dc4efd9
Compare
jstucke
force-pushed
the
highlighting-speedup
branch
from
dc4efd9 to
4c178af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
- Coverage 92.54% 91.90% -0.65%
==========================================
Files 379 378 -1
Lines 24008 21096 -2912
==========================================
- Hits 22219 19388 -2831
+ Misses 1789 1708 -81 ☔ View full report in Codecov by Sentry. |
jstucke
force-pushed
the
highlighting-speedup
branch
from
4c178af to
835b1c9
Compare
maringuu
approved these changes
Dec 18, 2024
| preview_button.onclick = load_preview; | ||
| let rawResultIsHighlighted = false; | ||
| const toggleSwitch = document.getElementById("rawResultSwitch"); | ||
| const analysisTable = document.getElementById("analysis-table-body"); |
There was a problem hiding this comment.
This is null if no analysis is selected (by clicking on the file name).
There was a problem hiding this comment.
Fixed. The variable analysisRows had the same problem
optimized code and replaced custom line numbering function with much faster lib
fixes the issue that the raw result is hidden by default but is considered for page height and scroll bar length nontheless
jstucke
force-pushed
the
highlighting-speedup
branch
from
835b1c9 to
4897fb3
Compare
maringuu
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.