Hash plugin v1 #1262
Merged
Hash plugin v1 #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jstucke
commented
Sep 5, 2024
jstucke
commented
- fixed a bug in AnalysisPluginV0 (summarize should not be abstract, since the summary is optional)
- migrated the hash plugin to the new base class
jstucke
force-pushed
the
hash-plugin-v1
branch
from
6016b89 to
1a39c88
Compare
maringuu
requested changes
Sep 12, 2024
jstucke
force-pushed
the
hash-plugin-v1
branch
from
1a39c88 to
fe3aaa2
Compare
maringuu
approved these changes
Nov 14, 2024
jstucke
force-pushed
the
hash-plugin-v1
branch
from
fe3aaa2 to
c9d3145
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
- Coverage 91.96% 91.86% -0.10%
==========================================
Files 377 376 -1
Lines 22360 20947 -1413
==========================================
- Hits 20564 19244 -1320
+ Misses 1796 1703 -93 ☔ View full report in Codecov by Sentry. |
jstucke
force-pushed
the
hash-plugin-v1
branch
from
c9d3145 to
1c22602
Compare
|
@jstucke I'm sorry, this needs another rebase. |
also moved methods from helperFunctions.hash that were used exclusively in the plugin into the plugin
jstucke
force-pushed
the
hash-plugin-v1
branch
from
1c22602 to
07a1359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.