plugin users&pws: ported to new base class

[jstucke]

No description provided.

[maringuu]

What is a "full_entry" supposed to be? I do not understand the description.

[jstucke]

"full_entry" is a full, unparsed entry, e.g.

admin:$5$Mqs9JzinZfyjSMNR$M7DWqlMjKmOHwfzXnts89eQImN2QNDATeN/Z/BX0Jb.:12332:0:99999:7:::

or if it doesn't contain a pw hash:

admin:*:12332:0:99999:7:::

This can be interesting if something went wrong (or sees to have gone wrong) during parsing or if the result is empty (because there is no hash)

[maringuu]

I personally find this less readable than not using a for loop. Also not using a for-loop is three lines less.

[jstucke]

The find_password_entries was also ugly and kinda useless, since it had only one line. I refactored it in a way that made more sense to me

[maringuu]

I'd propose a different schema:

class Schema(pydantic.BaseMode):
    unix: list[CreadentialResult]
    httpd: list[CredentialResult]
    mosquito: list[CredentialResult]

The class CrednetialResult would not have the type field anymore.

This way we could delete the _group_user_and_pw_results function and the schema would be more expressive imo.

[jstucke]

Changing the schema in this way also has disadvantages (like making it more complicated to add more password types or making it more complicated to iterate through all found pw entries) but I changed it (minus the typos 😅)

[jstucke]

I kept the type field, though, because without it, summary generation becomes unnecessarily ugly.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 95.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.84%. Comparing base (42f7320) to head (20b2e15).
Report is 19 commits behind head on master.

Files with missing lines	Patch %	Lines
...users_and_passwords/internal/credentials_finder.py	94.54%	3 Missing ⚠️
...users_and_passwords/code/password_file_analyzer.py	91.30%	2 Missing ⚠️
...sis/users_and_passwords/internal/crack_password.py	96.29%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1241      +/-   ##
==========================================
- Coverage   91.96%   91.84%   -0.12%     
==========================================
  Files         377      378       +1     
  Lines       22360    20929    -1431     
==========================================
- Hits        20564    19223    -1341     
+ Misses       1796     1706      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.