-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cve_lookup: added support for CVSS metrics v4.0+ #1233
Conversation
071c255
to
041ecc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1233 +/- ##
==========================================
- Coverage 92.23% 91.82% -0.41%
==========================================
Files 379 378 -1
Lines 23188 20927 -2261
==========================================
- Hits 21387 19217 -2170
+ Misses 1801 1710 -91 ☔ View full report in Codecov by Sentry. |
041ecc7
to
769a13a
Compare
@@ -20,6 +20,7 @@ | |||
from lookup import Lookup | |||
|
|||
DB_PATH = str(Path(__file__).parent / '../internal/database/cve_cpe.db') | |||
MINIMUM_CRITICAL_SCORE = 9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this value might change, we could consider making it configurable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
769a13a
to
cd3257c
Compare
KeyError
in the CVE data parsing