Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy: fix helper functions #1224

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Mypy: fix helper functions #1224

wants to merge 18 commits into from

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jun 3, 2024

supersedes #1123 and #1142

  • added mypy config to pyproject.toml
  • fixed mypy type issues in all modules in helperFunctions

this does not include the pre-commit hook yet (otherwise all other builds would fail after merging this PR)

@jstucke jstucke requested a review from maringuu June 3, 2024 14:39
@jstucke jstucke self-assigned this Jun 3, 2024
@jstucke jstucke force-pushed the mypy-helperfunctions branch 3 times, most recently from ffafaf1 to 6af6f0b Compare June 3, 2024 15:21
@jstucke jstucke force-pushed the mypy-helperfunctions branch from 6af6f0b to 235e8dd Compare October 31, 2024 15:25
@jstucke jstucke force-pushed the mypy-helperfunctions branch from 235e8dd to d89f92f Compare November 26, 2024 07:56
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 95.29412% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.86%. Comparing base (42f7320) to head (eb19521).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
src/helperFunctions/plugin.py 77.77% 2 Missing ⚠️
src/helperFunctions/fileSystem.py 0.00% 1 Missing ⚠️
src/objects/file.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1224      +/-   ##
==========================================
- Coverage   91.96%   91.86%   -0.11%     
==========================================
  Files         377      376       -1     
  Lines       22360    20952    -1408     
==========================================
- Hits        20564    19248    -1316     
+ Misses       1796     1704      -92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jstucke jstucke force-pushed the mypy-helperfunctions branch from 58d285b to eb19521 Compare November 27, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants