Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruff format #1189

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Ruff format #1189

merged 7 commits into from
Mar 6, 2024

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Jan 9, 2024

  • updated ruff version and rules
  • replaced black with ruff
  • checked, fixed and reformatted code with new ruff version

resolves #1187

@jstucke jstucke requested a review from maringuu January 9, 2024 15:54
@jstucke jstucke self-assigned this Jan 9, 2024
@jstucke
Copy link
Collaborator Author

jstucke commented Feb 28, 2024

Do we want to add any new rules?
Do we still need .github/workflows/lint_action.yml if we have ruff?
Was there a reason why "I" (=isort) was not enabled?

@maringuu
Copy link
Collaborator

maringuu commented Mar 6, 2024

Do not wonder, I prettified the history a bit :)

@maringuu maringuu self-requested a review March 6, 2024 09:16
@maringuu maringuu merged commit 1085351 into master Mar 6, 2024
7 of 9 checks passed
@maringuu maringuu deleted the ruff-format branch March 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff format instead of black
2 participants