Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle exception when part of a fw is reuploaded as fw #1151

Merged
merged 1 commit into from
Nov 7, 2023
Merged

handle exception when part of a fw is reuploaded as fw #1151

merged 1 commit into from
Nov 7, 2023

Conversation

jstucke
Copy link
Collaborator

@jstucke jstucke commented Oct 23, 2023 •
edited
Loading

@jstucke jstucke added the bug label Oct 23, 2023
@jstucke jstucke requested a review from maringuu October 23, 2023 08:10
@jstucke jstucke self-assigned this Oct 23, 2023
maringuu
maringuu approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@maringuu maringuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I would like to mention that I really don't like that we have this problem and it should be fixed, this workaround lgtm.

@maringuu maringuu merged commit c0552bb into master Nov 7, 2023
11 checks passed
@maringuu maringuu deleted the handle-extracted-file-reupload branch November 7, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maringuu maringuu maringuu approved these changes

Assignees

@jstucke jstucke

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jstucke @maringuu