-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3.12 support #1141
Python3.12 support #1141
Conversation
jstucke
commented
Oct 10, 2023
•
edited
Loading
edited
- replaced abandoned package 'si-prefix' with 'quantiphy'
- updated matplotlib version and no longer pin setuptools version
- remaining problems:
- aiohttp is incompatible Release 3.12 wheels aio-libs/aiohttp#7639
- fixed
- new release: should be fixed when 3.9 releases
- uwsgi is incompatible uWSGI 2.0.22 fails to build against Python 3.12 unbit/uwsgi#2566
- fixed Support for Python 3.12 (assistance required) unbit/uwsgi#2542
- new release
- yara-python < 4.4.0 is incompatible
- install new yara and yara-python
- update common_analysis_ip_and_uri
- aiohttp is incompatible Release 3.12 wheels aio-libs/aiohttp#7639
3908f90
to
5879f27
Compare
ssdeep installation should again work with the latest version of setuptools version 3.8 of matplotlib cannot be used yet, because it doesn't support Python3.8
and some additional dependencies which got new patches
If I'm not mistaken the code in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
# for string_instance in string_match.instances: | ||
|
||
strings = [(offset, identifier, data.hex()) for offset, identifier, data in match.strings] | ||
# see YARA docs: https://yara.readthedocs.io/en/latest/yarapython.html#yara.StringMatchInstance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think it is useful since you can't easily look at the YARA source (because it is a compiled C library)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, besides the nit
binwalk has not been updated for py3.12 support |