Fs metadata plugin v0 #1121
Merged
Fs metadata plugin v0 #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogous to changes in fs_metadata plugin
maringuu
requested changes
Sep 1, 2023
src/plugins/analysis/file_system_metadata/code/file_system_metadata.py
Outdated
Show resolved
Hide resolved
src/plugins/analysis/file_system_metadata/code/file_system_metadata.py
Outdated
Show resolved
Hide resolved
src/plugins/analysis/file_system_metadata/code/file_system_metadata.py
Outdated
Show resolved
Hide resolved
* removed mode_human_readable from schema * added description for "files" in schema * fixed bug in FS result where file name was used as key instead of path (leading to the results not being displayed for included files) * added filter for converting octal file mode to human readable * removed error logging
* much more compact * replaced alphabetical sorting with more logical sorting
|
lgtm |
maringuu
approved these changes
Oct 10, 2023
maringuu
pushed a commit
that referenced
this pull request
Oct 10, 2023
* removed mode_human_readable from schema * added description for "files" in schema * fixed bug in FS result where file name was used as key instead of path (leading to the results not being displayed for included files) * added filter for converting octal file mode to human readable * removed error logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
['result']) in plugin rest routes of fs_metadata and qemu_exec