crypto hints: Use plugin.PluginV0 #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maringuu
force-pushed
the
analysis-plugin-v1
branch
6 times, most recently
from
d31243d to
5e9e27f
Compare
maringuu
force-pushed
the
analysis-plugin-v1
branch
4 times, most recently
from
2388260 to
ab3ca5d
Compare
maringuu
force-pushed
the
analysis-plugin-v1
branch
2 times, most recently
from
f021852 to
402e19c
Compare
|
Converting to draft as this will definitely break the schema and I don't have schema migration ready yet. |
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
6f3cd87 to
5006e1a
Compare
|
Despite the missing database migration this is ready! |
maringuu
force-pushed
the
analysis-plugin-v1
branch
3 times, most recently
from
86df387 to
5081618
Compare
maringuu
force-pushed
the
analysis-plugin-v1
branch
2 times, most recently
from
a317446 to
2dd7b7c
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
5006e1a to
b13e8a1
Compare
31 tasks
maringuu
force-pushed
the
analysis-plugin-v1
branch
5 times, most recently
from
8d96aee to
edf4c71
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
b13e8a1 to
439843a
Compare
|
I'll leave out the database migration. |
maringuu
force-pushed
the
analysis-plugin-v1
branch
from
edf4c71 to
4067c84
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
439843a to
bd11200
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
bd11200 to
44d355c
Compare
maringuu
force-pushed
the
analysis-plugin-v1
branch
from
dbde681 to
503a753
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
44d355c to
032c1e2
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
032c1e2 to
625fcab
Compare
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
2 times, most recently
from
bbc2bea to
3b7008a
Compare
jstucke
reviewed
Jan 18, 2024
There was a problem hiding this comment.
In some cases the matching strings appear as strings instead of hex strings (which was not the case in the old version). This can lead to some rather odd results in the web interface:
I'm guessing this is a problem of the YARA addon or compat class and not the plugin.
Apart from that, everything looks fine
maringuu
force-pushed
the
analysis-plugin-v1-crypto-hints
branch
from
3b7008a to
8c706f1
Compare
jstucke
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #987