Skip to content

Commit

Permalink
fix(plugins): Don't crash when result is None
Browse files Browse the repository at this point in the history
The idea here as to have the symmetry that when result is None
the tags would also be None.
While I like this in general this was not thought out.
The get_tags signature did not allow this and the rest of the codebase
was not build with this in mind.
  • Loading branch information
maringuu authored and jstucke committed Aug 28, 2023
1 parent 1342263 commit 9053b85
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/analysis/plugin/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def get_analysis(self, file_handle: io.FileIO, virtual_file_path: dict, analyses
result = self.analyze(file_handle, virtual_file_path, analyses)

summary = None
tags = None
tags = []
if result is not None:
summary = self.summarize(result)
tags = self.get_tags(result, summary)
Expand Down

0 comments on commit 9053b85

Please sign in to comment.