Skip to content

Commit

Permalink
scheduler: Don't drop FileObject when dependencies are not met
Browse files Browse the repository at this point in the history
Citing @jstucke

> we should probably call
> self._check_further_process_or_complete(file_object) here because it
> might still be possible to do other analyses (instead of just
> dropping the FO). What is more, the analysis progress is not
> calculated correctly if the FO vanishes from scheduling and the FW
> will hang indefinitely in "current analyses"
  • Loading branch information
maringuu committed Jul 31, 2023
1 parent 07cd3bf commit 503a753
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/scheduler/analysis/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,6 +362,7 @@ def _start_or_skip_analysis(self, analysis_to_do: str, file_object: FileObject):

if _dependencies_are_unfulfilled(plugin, file_object):
logging.error(f'{file_object.uid}: dependencies of plugin {plugin.metadata.name} not fulfilled')
self._check_further_process_or_complete(file_object)
return

runner.queue_analysis(file_object)
Expand Down

0 comments on commit 503a753

Please sign in to comment.