-
-
Notifications
You must be signed in to change notification settings - Fork 702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v11 omit styling #1189
Comments
i actually just confirmed this is exactly the case by deleting the injected styles that get added to the DOM.
When i deleted that, my component worked as expected. |
Hey @reintroducing sorry for the trouble, wasn't expecting people to use the library without any style. I can add an export like |
@fkhadra no worries at all, yep that would be perfect, I wrap the library with my own component that conforms to my UI style guide so the import only happens in one place. Much appreciated. |
@reintroducing v11.0.2 should contains the new export. May I ask you to close the issue after confirming it work as expected on your side? Thank you |
The current automatic style injection looks like incompatible with React Router v7 + Tailwind configuration causing hydration errors due to duplicated dangerouslySetInnerHtml in |
@tats-u could you share your setup on stackblitz? That would help me troubleshoot the issue |
That error appear only in the F12 console, so I will reproproduce there in this weekend or next week. |
Ok thank you. For now you can import from |
Thank you for the information. |
@fkhadra confirmed this is working as expected with the new import. thank you very much for the quick turn around, much appreciated. |
@fkhadra Thanks a ton for We use custom toast styling and different positioning of the same toast container based on media queries for different devices, which is cleanly achievable when styling from scratch, but is a pain when trying to override defaults. Having an option and versatility to import css separately is always a huge plus for many reasons (our use case included). P.S.: If it's possible, it would be great to have this |
Hey @SaveliiLukash sorry for the trouble 😞. I forgot to update the documentation after adding the |
I just upgraded to v11 and it broke my component. I was previously not using the styling at all (so not loading the CSS) and had written custom styles based on classNames I passed to control the UI. With v11, I believe this is broken because the styles are automatically injected into the code, with seemingly no option to opt out of that (I don't see anything in the docs). Is there a way to disable the default styling that comes with v11? I'm seeing styles added in the dev tools that were not there in the prior version.
The text was updated successfully, but these errors were encountered: