Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XS_Jet model to xspec-models #74

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Add XS_Jet model to xspec-models #74

merged 2 commits into from
Nov 28, 2023

Conversation

phajy
Copy link
Contributor

@phajy phajy commented Nov 27, 2023

Added the interface to XS_Jet, the jet model in XSPEC. Just realised I forgot the nice ASCII art overview plot to go with the model.

@fjebaker
Copy link
Owner

Thanks Andy! Request a review from me when you're ready to have it merged :)

@phajy
Copy link
Contributor Author

phajy commented Nov 27, 2023

Plot added. I'll request a review :)
EDIT: Don't think I can request a review directly, so will just have to request in the text here!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56f0ba4) 66.90% compared to head (b00b6f5) 66.83%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   66.90%   66.83%   -0.07%     
==========================================
  Files          40       40              
  Lines        1988     1990       +2     
==========================================
  Hits         1330     1330              
- Misses        658      660       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@fjebaker fjebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fjebaker fjebaker merged commit c402071 into fjebaker:main Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants