Skip to content

Commit

Permalink
feat(helm-values): Add "all" flags to query params (#178)
Browse files Browse the repository at this point in the history
  • Loading branch information
jarojasm95 authored Oct 18, 2024
1 parent c739e5d commit 6288e28
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
8 changes: 6 additions & 2 deletions aladdin/commands/helm_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from aladdin.lib.helm_rules import HelmRules
from aladdin.lib.k8s.helm import Helm
from aladdin.lib.project_conf import ProjectConf
from aladdin.lib.utils import working_directory
from aladdin.lib.utils import working_directory, strtobool


def parse_args(sub_parser):
Expand Down Expand Up @@ -63,7 +63,7 @@ def helm_values(
output: str = None,
):
uri = urlparse(uri)
params = dict(parse_qsl(uri.query))
params = dict(parse_qsl(uri.query, keep_blank_values=True))
os.environ["CLUSTER_CODE"] = uri.netloc
repo_name = uri.path.lstrip("/")
ClusterRules(namespace=namespace)
Expand All @@ -72,6 +72,10 @@ def helm_values(
git_ref or params.get("git-ref") or Git.get_full_hash(),
f"git@github.com:{git_account}/{repo_name}.git" if repo_name else None
)
if "all" in params:
if params.get("all") == "":
params["all"] = "true"
all_values = strtobool(params.get("all"))

with clone_and_checkout(git_ref, repo_name, debug=HelmRules.debug) as repo_dir:
current_chart_name = get_current_chart_name()
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "aladdin"
version = "1.29.8.3"
version = "1.29.8.4"
description = ""
authors = ["Fivestars <dev@fivestars.com>"]
include = [
Expand Down

0 comments on commit 6288e28

Please sign in to comment.