Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG Fix: Add href Attribute to <a> Tag for Project Card (Fixes #416) #418

Open
wants to merge 1 commit into
base: source
Choose a base branch
from

Conversation

sharif2552
Copy link

@sharif2552 sharif2552 commented Aug 15, 2024

🐞 Problem

The <a> tag in the project card component was missing an href attribute. This omission prevented the card from functioning as a clickable link, thus not directing users to the intended project URL. (Issue #416)

💡 Solution

I resolved the issue by updating the project card component's data to include the correct projectLink attribute, which is used as the href in the <a> tag. The specific change was:

  • Updated the project card data to replace the githubLink attribute with projectLink to ensure it correctly reflects the link's purpose.

🔧 Implementation Details

  • The projectLink is now correctly passed as the href for the <a> tag.
  • The image URL has also been updated to include the ?raw=true parameter, ensuring the image is rendered correctly.

✅ Testing

  • Verified that the Project Card component is now a functional link by clicking the card and ensuring it navigates to the intended GitHub project.
  • Updated relevant test cases to include checks for the presence and functionality of the href attribute.

🔗 Related Issue

This pull request fixes issue #416.

@sharif2552 sharif2552 changed the title BUG fixes : Missing href Attribute in <a> Tag for Project Card->{aprenda-go-com-testes} #416 BUG Fix: Add href Attribute to <a> Tag for Project Card (Fixes #416) Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant