Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix division by zero error during acc calculation #113

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

erkankarabulut
Copy link

This pull request is relevant to the following issue: #112.

In rule.py, while calculating acc as part of amplitude rule quality criterion, the code throws a division by zero warning if the feature_max == feature_min.

In that case, acc is increased by one, instead of the division.

@firefly-cpp
Copy link
Owner

Thanks, @erkankarabulut

@firefly-cpp firefly-cpp merged commit 89501d1 into firefly-cpp:main Mar 13, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants