Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[History] Feature/mas 1759 get transfers #146

Draft
wants to merge 23 commits into
base: develop
Choose a base branch
from
Draft

[History] Feature/mas 1759 get transfers #146

wants to merge 23 commits into from

Conversation

adsorptionenthalpy
Copy link
Member

@adsorptionenthalpy adsorptionenthalpy commented May 28, 2020 •
edited
Loading

Change Description

  • Create get_transfers endpoint
  • Make get_transfers return specific information about transfers
  • Add transfers object to contract_types to support deserializing transfer action data
  • Support for trnsfiopbky, transfer
  • Fees collected from transaction are extracted and displayed in transfer_information record
  • subtransactions of trnsfiopbky are excepted from displaying transfers

@0xCasey 0xCasey self-requested a review May 28, 2020 04:19
adsorptionenthalpy and others added 19 commits May 28, 2020 10:00
@adsorptionenthalpy
Add get_transfers support for xferdomain/xferaddress
eaa17ef
@adsorptionenthalpy
Skip over emplacing unprocessed transcation information
1887a6d
@adsorptionenthalpy
parse json response for fee_amount
50b41a2
@githubStinks
work on fee extraction
196d607
@githubStinks
alter transaction record names to use payee/payer, use public key for…
54d0566 
… lookup param
@adsorptionenthalpy
Merge branch 'develop' into feature/MAS-1759-get_transfers
dd4a24c
@adsorptionenthalpy
Except subtransfers after trnsfiopbky (dup trx id handling)
87af0e6
@adsorptionenthalpy
Rewrite logic, bugfix
a588b99
@adsorptionenthalpy
Enable lookup time limit, limit by 100000 us * 3, increase max sequen…
c19259d 
…ce numbers 1000 * 3
@adsorptionenthalpy
move the 3
b818038
@adsorptionenthalpy
rename ti.block_height to block_num, add account_action_seq and globa…
b2b95b1 
…l_action_seq
@adsorptionenthalpy
Allow result for trnfiopbky hashed down payee pub key in get_transfers
2219c7f
@adsorptionenthalpy
additional filter in logic (get_transfers
f7b64b7
@adsorptionenthalpy
handle subtransfer
c6e62f4
@adsorptionenthalpy
revert previous work, move previoustrx condition to trnsfiopbky filter
36aafaf
@adsorptionenthalpy
Add transferdata to/from fields to transfer filtering
66a7e19
@adsorptionenthalpy
Make transfer_amount field optional for fee transfers to fio.treasury
d9bfd6e
@adsorptionenthalpy
fix parenthesis placement
3e4b33c
@adsorptionenthalpy
set amounts to 0 instead of omitting the fields
c17927f
@adsorptionenthalpy adsorptionenthalpy marked this pull request as ready for review July 13, 2020 18:00
@ericbutz ericbutz changed the title Feature/mas 1759 get transfers [History] Feature/mas 1759 get transfers Oct 21, 2020
@ericbutz ericbutz marked this pull request as draft October 21, 2020 16:19
@ericbutz
Copy link
Contributor

We only want to roll this out in V1 history if we plan on supporting a similar endpoint in the new State History and/or Hyperion. Need to discuss this in the context of the EOSIO 2.x FIO upgrade.

@ericbutz
Copy link
Contributor

ericbutz commented Feb 18, 2021 •
edited
Loading

Putting the get_transfers endpoint on hold. It is part of a larger discussion with wallets and exchanges regarding what, if any, issues they are encountering with accessing transaction data. If it is determined that a new endpoint is needed to access transaction data, we can re-open the story.

Keeping the branch in Draft for now.

Tracked in: https://fioprotocol.atlassian.net/browse/BD-2363

Johnlabo3
Johnlabo3 reviewed Feb 22, 2022
View reviewed changes
Copy link

@Johnlabo3 Johnlabo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#338

misterleet pushed a commit that referenced this pull request Jul 15, 2022
@ericbutz
Merge pull request #146 from fioprotocol/eric/staking-testing
ecdffaf 
Updates to max period and timing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johnlabo3 Johnlabo3 Johnlabo3 left review comments

@0xCasey 0xCasey 0xCasey approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@adsorptionenthalpy adsorptionenthalpy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adsorptionenthalpy @ericbutz @0xCasey @Johnlabo3 @githubStinks