1255 Make fdc3.fileAttachment an independent type

[Yannick-Malins]

#1255

[netlify]

✅ Deploy Preview for fdc3 ready!

Name	Link
🔨 Latest commit	92ecb7a
🔍 Latest deploy log	https://app.netlify.com/sites/fdc3/deploys/670f678646cd4d0008e25ca9
😎 Deploy Preview	https://deploy-preview-1261--fdc3.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[Yannick-Malins]

@kriswest

[kriswest]

LGTM - although I think Message's entities element needs to be defined with oneOf rather than anyOf. Could you change that, add a Changelog entry and then I'll approve and merge the change (new governance restrictions will invalidate any reviews that happen before a later change)

[kriswest]

@Yannick-Malins lemme know if you can make these two quick changes (I didn't add suggestions or I won't be able to review the change after you merge them) - alternatively let me know to re-raise this PR and have you review instead.

[kriswest]

Todo:

• the filename and this $id need to match in fileAttachment.schema.json
• define message entities with oneOf rather than anyOf in message.schema.json
• add a changelog

[kriswest]

Thanks @Yannick-Malins. I'm not seeing the new type in the preview - but that could be because the PR is '199 commits behind finos/FDC3:main'. Could you merge changes from main then run npm run build. That should re-generate ContextTypes.ts so that goes in and the preview should generate correctly afterwards (those two are unrelated but we need to check both).

Otherwise looks all good to me. I'll get around to adding a PR template soon so the above steps are documented!

[Yannick-Malins]

should be good now!

[kriswest]

LGTM, thanks @Yannick-Malins

Docs page:
https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/FileAttachment

Page that links to new docs page:
https://deploy-preview-1261--fdc3.netlify.app/docs/next/context/ref/Message

[kriswest]

LGTM