Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test setup and QueryIntegrationSpec completed. #69

Merged
merged 1 commit into from
May 12, 2016
Merged

Integration Test setup and QueryIntegrationSpec completed. #69

merged 1 commit into from
May 12, 2016

Conversation

penland365
Copy link
Contributor

Integration tests were added to core to test essential functionality with CREATE / INSERT / UPDATE / SELECT / DELETE / DROP. Integration tests require a Postgresql installation, a database named "circle_test", and a user named "ubuntu" to conform to the circle_ci setup. These integration tests DO NOT run under the base sbt test:test or sbt test commands, so having a Postgresql installation for basic development shouldn't be needed.

This partially addresses #65 .

Integration tests were added to core to test essential functionality
with CREATE / INSERT / UPDATE / SELECT / DELETE / DROP. Integration
tests require a Postgresql installation, a database named "circle_test",
and a user named "ubuntu" to conform to the circle_ci setup. These
integration tests DO NOT run under the base sbt test:test or sbt test
commands, so having a Postgresql installation for basic development
shouldn't be needed.

This partiall addresses #65 .
@codecov-io
Copy link

Current coverage is 86.97%

Merging #69 into master will increase coverage by +10.76%

  1. 4 files (not in diff) in ...postgresql/transport were modified. more
    • Misses -7
    • Hits +7
  2. 3 files (not in diff) in ...scala/roc/postgresql were modified. more
    • Misses -29
    • Hits +29
  3. 1 files (not in diff) in ...e/src/main/scala/roc were modified. more
    • Misses -8
    • Hits +8
  4. File ...ientDispatcher.scala was modified. more
    • Misses -37
    • Partials 0
    • Hits +37
@@             master        #69   diff @@
==========================================
  Files            18         18          
  Lines           761        760     -1   
  Methods         753        749     -4   
  Messages          0          0          
  Branches          8         11     +3   
==========================================
+ Hits            580        661    +81   
+ Misses          181         99    -82   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 6ab971e...f2bfd2b

@penland365 penland365 merged commit 3f24413 into finagle:master May 12, 2016
@penland365 penland365 deleted the integration-tests branch May 31, 2016 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants