Introduced the Buf type as Readable / Writeable Array Buffer. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ChannelBuffer backed implementation of Buffer used currently ( and borrowed from finagle-mysql ) has 3 issues - it generates a lot of garbage with separate Reader / Writer classes, it's based on Netty3, and it doesn't correctly write all UTF-8 encoded strings to it's buffer. The Buf type was introduced to address this. As of this commit, nothing internal to roc-core will use this new type outside of tests. Conversion of existing Buffer uses will take place gradually prior to finagle-4 being introduced. There is still work to be done in completing Benchmarks. This partially addresses #48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChannelBuffer backed implementation of Buffer used currently ( and borrowed from finagle-mysql ) has 3 issues - it generates a lot of garbage with separate Reader / Writer classes, it's based on Netty3, and it doesn't correctly write all UTF-8 encoded strings to it's buffer.
The Buf type was introduced to address this. As of this commit, nothing internal to roc-core will use this new type outside of tests. Conversion of existing Buffer uses will take place gradually prior to finagle-4
being introduced.
There is still work to be done in completing Benchmarks.
This partially addresses #48 .