Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine TODO App example #1020

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Refine TODO App example #1020

merged 1 commit into from
Nov 14, 2018

Conversation

vkostyukov
Copy link
Collaborator

@vkostyukov vkostyukov commented Nov 2, 2018

I was playing around the idea of doing better job with our examples to make them more appealing. This PR adds an HTML frontend for a Finch app. It looks like this.

screen shot 2018-11-01 at 9 06 50 pm

Additionally this:

Curious to hear what people think about this.

@codecov-io
Copy link

codecov-io commented Nov 2, 2018

Codecov Report

Merging #1020 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage   84.08%   84.13%   +0.05%     
==========================================
  Files          49       49              
  Lines         949      952       +3     
  Branches       61       59       -2     
==========================================
+ Hits          798      801       +3     
  Misses        151      151
Impacted Files Coverage Δ
core/src/main/scala/io/finch/EndpointResult.scala 80.95% <66.66%> (-2.39%) ⬇️
core/src/main/scala/io/finch/Endpoint.scala 72.89% <0%> (+0.6%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb7da43...214e41b. Read the comment docs.

@sergeykolbasov
Copy link
Collaborator

I'd play with fonts, but otherwise, it's good 😄

👍

@@ -2,7 +2,7 @@ package io.finch

import cats.Applicative
import cats.data.NonEmptyList
import cats.effect.{Effect, Sync}
import cats.effect.{ContextShift, Effect, Sync}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import?

@vkostyukov vkostyukov merged commit 95f1e69 into master Nov 14, 2018
@vkostyukov vkostyukov deleted the vk/todo-with-html branch November 14, 2018 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants