Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov support #38

Merged
merged 1 commit into from
Sep 2, 2016
Merged

Conversation

rpless
Copy link
Contributor

@rpless rpless commented Aug 18, 2016

Add code coverage reporting (via Codecov.io)
Notes:

  • If you choose to accept this PR then you will need to log into codecov before accepting so that it can set itself up to do reporting
  • This uses a slightly out of date version of scoverage because of Support cross-build for Scala 2.10 #18. the latests scoverage does not seem to work with 2.10. if you decide to drop 2.10 support then we can update to 1.3.5

related: #17

see codecov report for my branch: https://codecov.io/gh/rpless/featherbed/branch/feature%2Frpless%2Fcodecov

@codecov-io
Copy link

Current coverage is 62.45% (diff: 100%)

No coverage report found for master at 2023cfc.

Powered by Codecov. Last update 2023cfc...7da5803

@rpless
Copy link
Contributor Author

rpless commented Aug 18, 2016

Or I guess my first bullet is incorrect and codecov will accept anything from a public repo.

@jeremyrsmith
Copy link
Collaborator

Thanks for doing this @rpless!

@jeremyrsmith jeremyrsmith merged commit b146094 into finagle:master Sep 2, 2016
@rpless rpless deleted the feature/rpless/codecov branch September 2, 2016 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants