-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade hwloc #1766
fix: upgrade hwloc #1766
Conversation
Hello @jmg-duarte -- thanks for submitting this, we'll take a look! |
@cryptonemo I just noticed the I can't quite understand why since the docs I pointed too seem to indicate it should work? Thanks! |
That particular test can fail if other tests are running at the same time. CI should isolate it properly. |
If |
CI aside, what we need for this to 'cut it' is to determine if there's any noticeable (negative) performance impact on multicore-sdr sealing (in particular for production sector sizes of 32/64GiB). Gathering that data will take some time. |
My testing of production sectors checks out(!) @DrPeterVanNostrand @vmx Any inputs, or good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cryptonemo Thanks for testing it out. I think then it's good to go.
When running
rust-fil-proofs
under Rust 1.81 the following warning is issued:The package depending on
bitflags
0.7.0 ishwloc
, which has been replaced byhwloc2
.Understandably,
hwloc
(the original library) has suffered changes as well, which are reflected inhwloc2
.The main one being the removal of
allowed_cpuset
, according to thehwloc
upgrading guide (https://www.open-mpi.org/projects/hwloc/doc/v2.8.0/a00374.php#upgrade_to_api_2x_allowed) thesecpuset
should be enough given that theINCLUDE_DISALLOWED
flag hasn't been passed (and as far as I know, it isn't a default).This PR attempts to address these issues.