Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom command #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

asteurer
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>

saving work

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>

saving work

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>

updating version

Signed-off-by: Andrew Steurer <andrew.steurer@fermyon.com>
@karthik2804
Copy link
Contributor

Would it make sense to allow more than one custom build? I for one have aliases for spinrelease and spindebug pointing at release and debug builds

Copy link

@kate-goldenring kate-goldenring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To @karthik2804's point, it would be

Create/update a pointer to a custom version:

```sh
spin verman set custom --file path/to/spin/binary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do paths not have to be absolute?

Create/update a pointer to a custom version:

```sh
spin verman set custom --file path/to/spin/binary

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to @karthik2804's point, it would be great to have something along the lines of:

spin verman set <user-chooses-name> /path

verman would know that it is a custom entry due to the path being provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants