You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When installing https://phanpy.social as a Custom Website, clicking on a profile opens the profile overlay drawer like in a browser
Actual Behavior
Nothing happens in Ferdium and the profile URL is opened in an external browser
Screenshots
No response
Additional Information
This likely affects other services/websites and is due to the way franz-custom-website's webview.js is implemented. When an HTML <a> element is clicked, ferdium will open the URL in its href attribute even if the website has installed a click event handler that overrides browser behaviour to trigger in-page navigation or some other action.
instead of explicitly replicating default behaviour by changing window.location, when trapLinkClicks is true, ferdium should not call event.preventDefault() or event.stopPropagation(), or simply not install the click handler at all.
The text was updated successfully, but these errors were encountered:
Preflight Checklist
Ferdium Version
7.0.0
Recipe Name
Custom Website
Recipe Version
1.5.1
Last Known working version of the recipe
No response
Steps to reproduce
Expected Behavior
When installing https://phanpy.social as a Custom Website, clicking on a profile opens the profile overlay drawer like in a browser
Actual Behavior
Nothing happens in Ferdium and the profile URL is opened in an external browser
Screenshots
No response
Additional Information
This likely affects other services/websites and is due to the way
franz-custom-website
'swebview.js
is implemented. When an HTML<a>
element is clicked, ferdium will open the URL in itshref
attribute even if the website has installed aclick
event handler that overrides browser behaviour to trigger in-page navigation or some other action.This is compounded by the fact that the
trapLinkClicks
("Open URLs within Ferdium") setting does not fully deactivate Ferdium's meddling withclick
events:https://github.com/ferdium/ferdium-recipes/blob/main/recipes/franz-custom-website/webview.js#L27
instead of explicitly replicating default behaviour by changing
window.location
, whentrapLinkClicks
is true, ferdium should not callevent.preventDefault()
orevent.stopPropagation()
, or simply not install the click handler at all.The text was updated successfully, but these errors were encountered: