Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort queues by # of jobs with a particular status on the dashboard #875

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

diivi
Copy link

@diivi diivi commented Jan 11, 2025

Hi, thank you for the amazing work you do to maintain this project! It has been incredibly helpful to me recently, and I wanted to give back in some way.

This is my attempt to fix #572

I went with sorting the queues on the frontend, let me know if (and how?) this should be done on the backend.

Screen.Recording.2025-01-11.at.11.02.28.PM.mov

@felixmosh
Copy link
Owner

I didn't forgot about this PR, I'm a bit busy lately, I'll review it ASAP

@felixmosh
Copy link
Owner

Hi, did you know that you can click on the relevant status, to show only queues with jobs with that status?
Does it solves your requirement?

@diivi
Copy link
Author

diivi commented Jan 20, 2025

Yeah, I know that but I think #572 requested this particular sorting feature so I tried implementing it.

@shane-streettext
Copy link
Contributor

@diivi This is a useful feature I'd look forward to using.

One question/suggestion -- if the user selects the same sort column a second time, would it sort in reverse order?

eg.
Sort -> Alphabetical -> Sorts A-Z
Sort -> Alphabetical (again) -> Sorts Z-A

I could see both ascending and descending options being useful in different scenarios.

@felixmosh
Copy link
Owner

Can you rebase this PR?

@diivi diivi force-pushed the feat/sort-queues-by-status branch from e476c96 to 44b0d3e Compare March 27, 2025 09:36
@diivi
Copy link
Author

diivi commented Mar 27, 2025

if the user selects the same sort column a second time, would it sort in reverse order?

Thanks for the suggestion, I'll try to work it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add sorting to 'dashboard'
3 participants