-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Group queues in Menu #867
Conversation
This change enhances the flexibility of queue configurations by allowing the specification of a delimiter.
- Introduced a new `QueueTree` component to render queues in a hierarchical structure based on a delimiter. - Updated the `Menu` component to utilize the new `QueueTree` for displaying queues. - Enhanced CSS styles for the menu, including padding adjustments and added margin for nested levels.
…ierarchy support)
Hi, thank you for this PR. |
Thanks for your quick reply 🙂 This PR implements #633 Here are notable things in this PR:
const newRegistration = createQueueMQ('Notifications.User.NewRegistration');
const resetPassword = createQueueMQ('Notifications.User.ResetPassword');
createBullBoard({
queues: [
new BullMQAdapter(newRegistration, { delimiter: '.' }),
new BullMQAdapter(resetPassword, { delimiter: '.' }),
],
serverAdapter,
});
I welcome any feedback. Thanks to all contributors. REC-20250102160303.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the code looks awsome 🙏🏽
Thank you for this PR, it will implement a much request feature :]
…for improved performance
Thank you for your review @felixmosh, really appreciate your feedback. |
Im AFK at the weekend, will publish it on Monday. |
I've noticed a bug, the nav link links to queues final part (which is not the full queue name), therefore, it returns, Queue not found. I'll fix it. |
Thank you for this PR, it released in |
@ahnwarez I don't use delimiter but some prefixes. How can I use this feature? for examples:
|
You can try to set the prefix to be a; , b; |
There are optional parameters to set the delimiter and in the example below it's // before
createBullBoard({
queues: [
new BullMQAdapter(exampleBullMq, { delimiter: '.' }),
new BullAdapter(exampleBull, { delimiter: '.' }),
new BullMQAdapter(newRegistration, { delimiter: '.' }),
new BullMQAdapter(resetPassword, { delimiter: ':' }),
],
serverAdapter,
}); // after
createBullBoard({
queues: [
new BullMQAdapter(exampleBullMq, { delimiter: '-' }),
],
serverAdapter,
}); I hope this answers your question 🙂 |
My queues are named as |
This works. However, with my queues are all wrapped with curly braces (e.g. As of why I name queues like that, see Hash tags. Is there an option I can use to handle this case? |
@andreasciamanna can you open a separate bug? |
Of course. I wasn't sure if it was a bug or just an option I should set. |
No description provided.