Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display flex for native scrolling #327

Closed
wants to merge 1 commit into from
Closed

display flex for native scrolling #327

wants to merge 1 commit into from

Conversation

WardCunningham
Copy link
Member

@WardCunningham WardCunningham commented Oct 25, 2024

@baldurbjarnason has guided me through this modest improvement styling the lineup using flex for native scrolling. This is expected to work better on mobile. (Test this before merging.)

Note: this and related work is more about investing in the longevity of our codebase than adding mobile as a feature. I once referred to this as "chronological scaling" before we had a clear notion of what that would require. post

@paul90
Copy link
Member

paul90 commented Oct 26, 2024

Only thing I've spotted so far is that the horizontal scrollbar on the lineup needs hiding, and page being opened no longer is scrolled into view. No auto scrolling the lineup to bring the new page into view is most likely a fault in the JS conversion!, looks to be something jQuery related that get broken here.

@WardCunningham
Copy link
Member Author

WardCunningham commented Oct 26, 2024

@paul90 recommended this simple fix, bfa2e8b, and adds, "if we were not moving away from browserify it could be fixed by adding browserify-optional into the mix."

Rendering on older iPad.
IMG_0053

Rendered on old iPhone.
IMG_9404

@WardCunningham
Copy link
Member Author

Direct positioning within the lineup happens when a specific page is made active. This is handled by code in active.coffee. Changes here have thrown off these calculations.

Various places in the code will expose a particular page and make it active with idiomatic code that looks like:

active.set($('.page').last())

We see calls like this in these modules:

  • factory.coffee -- once
  • link.coffee -- twice
  • state.coffee -- once
  • search.coffee -- unused, now obsolete by pop-up?
  • legacy.coffee -- seven times, in various global event handlers

(cherry picked from commit ef11b67)
(cherry picked from commit 8a6ef76)
@paul90
Copy link
Member

paul90 commented Nov 2, 2024

Cherry picking the change here to the new decaffeinated main branch added a bunch of commits from the migration. Restored by force-push, this PR will be closed and reopened on the new main branch.

@paul90 paul90 changed the base branch from legacy to main November 3, 2024 12:30
@paul90 paul90 changed the base branch from main to legacy November 3, 2024 12:30
@paul90
Copy link
Member

paul90 commented Nov 3, 2024

Closed in favour of #328, based on the JavaScript main branch.

@paul90 paul90 closed this Nov 3, 2024
@paul90 paul90 deleted the newcss branch February 25, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants