Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken plugin dialog #316

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Fix broken plugin dialog #316

merged 3 commits into from
Mar 8, 2024

Conversation

paul90
Copy link
Member

@paul90 paul90 commented Mar 1, 2024

No description provided.

@WardCunningham
Copy link
Member

WardCunningham commented Mar 2, 2024 •
edited
Loading

This seems to be missing the error message, wiki.dialog ex.toString(), that we once put in the title/heading of the jQuery dialog. Maybe that text would be best treated as an H3 or similar?

@WardCunningham
Copy link
Member

WardCunningham commented Mar 6, 2024 •
edited
Loading

Thanks. Merge encouraged.

@paul90 paul90 merged commit 8edad37 into master Mar 8, 2024
3 checks passed
@paul90 paul90 deleted the fix-broken-plugin branch March 8, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul90 @WardCunningham