URL parsing check and documentation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The first round of feedback is addressed in the fixup commit. The URLs that cause the warning to be raised are not allowed anymore. |
hroncok
reviewed
Oct 3, 2024
hroncok
reviewed
Oct 8, 2024
hroncok
reviewed
Oct 8, 2024
|
The last two fixup commits contain:
@hroncok could you please eyeball it before I merge it and release it? |
hroncok
approved these changes
Oct 8, 2024
frenzymadness
force-pushed
the
url_parsing
branch
from
453a9e9 to
5cd2a10
Compare
`urllib.parse` does not perform any input validation so its output might be invalid as well. Because host_whitelist functionality relies on hostnames parsed from URLs, the result of `urlsplit` is newly compared with the result of simple regex parser and If they differ, a warning is raised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise warning for unstable URL parsing
urllib.parsedoes not perform any input validation soits output might be invalid as well. Because host_whitelist
functionality relies on hostnames parsed from URLs, the result of
urlsplitis newly compared with the result of simple regexparser and If they differ, a warning is raised.