Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Teal Mask DLC data #890

Merged
merged 42 commits into from
Nov 27, 2023
Merged

Add Teal Mask DLC data #890

merged 42 commits into from
Nov 27, 2023

Conversation

favna
Copy link
Member

@favna favna commented Nov 20, 2023

TODO:

  • Add Ogerpon and forms
  • Add flavor texts for the pokemon added in kitakami dex (including older mons newly added)
  • Add flavor texts for the many ogerpon forms (manual, don't think the script will work here)
  • Add flavor texts for the Poltchageist and Sinistcha forms (manual, don't think the script will work here)
  • Update pokemon enum in the graphql file
  • Update src/lib/types/graphql-mapped-types.ts by regenerating the file
  • Update tests
  • Update tests/testUtils/types.d.ts by regenerating the file
  • Validate all data
  • Validate offset and take maximums are correct
  • Validate images for the new items

ref: https://raw.githubusercontent.com/smogon/pokemon-showdown/master/data/pokedex.ts

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@favna favna force-pushed the feat/add-teal-mask-dlc-data branch from 57a9357 to 7cab7dd Compare November 27, 2023 21:52
@favna favna marked this pull request as ready for review November 27, 2023 22:38
@favna favna merged commit d06ebf5 into main Nov 27, 2023
8 checks passed
@favna favna deleted the feat/add-teal-mask-dlc-data branch November 27, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant