fix loopback server port for login (#565)

* fix loopback server port for login * verify in test that server starts before we get the redirect uri
fauna · Jan 16, 2025 · 9978587 · 9978587
1 parent fdc2f3d
commit 9978587
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 7 deletions.
diff --git a/src/commands/login.mjs b/src/commands/login.mjs
@@ -38,22 +38,29 @@ async function doLogin(argv) {
       logger.stderr(err);
     }
   };
-  const authCodeParams = oAuth.getOAuthParams({
-    clientId: argv.clientId,
-    noRedirect: argv.noRedirect,
-  });
-  const dashboardOAuthURL = await startOAuthRequest(authCodeParams);
-  logger.stdout(`To login, open a browser to:\n${dashboardOAuthURL}`);
+
+  const promptLoginUrl = async () => {
+    const authCodeParams = oAuth.getOAuthParams({
+      clientId: argv.clientId,
+      noRedirect: argv.noRedirect,
+    });
+    const dashboardOAuthURL = await startOAuthRequest(authCodeParams);
+    logger.stdout(`To login, open a browser to:\n${dashboardOAuthURL}`);
+    return dashboardOAuthURL;
+  };
+
   if (!argv.noRedirect) {
     oAuth.server.on("ready", async () => {
+      const dashboardOAuthURL = await promptLoginUrl();
       open(dashboardOAuthURL);
+      logger.stdout("Waiting for authentication in browser to complete...");
     });
     oAuth.server.on("auth_code_received", async () => {
       await loginWithToken();
     });
     await oAuth.start();
-    logger.stdout("Waiting for authentication in browser to complete...");
   } else {
+    await promptLoginUrl();
     try {
       const userCode = await input({
         message: "Authorization Code:",

diff --git a/test/commands/login.mjs b/test/commands/login.mjs
@@ -111,6 +111,8 @@ describe("login", function () {
 
     // We start the loopback server
     expect(oauthClient.start.called).to.be.true;
+    expect(oauthClient.start.calledBefore(oauthClient.getOAuthParams)).to.be
+      .true;
     // We open auth url in the browser and prompt user
     expect(container.resolve("open").calledWith("http://dashboard-url.com"));
     expect(logger.stdout).to.have.been.calledWith(