Use text/template instead of html/template for config pre-processing #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit c95311d added support for multiple config formats in addition to pre-processing using Go's built-in templating system. The `html/template` package is equivalent to `text/template`, except that the former automatically escapes characters for inclusion in HTML. Configurations aren't plain text, but they're also certainly no HTML. The difference between the packages is noticeable when using `printf "%q"` for quoting of strings. An example from the included unittest: * `html/template`: `key = &fatedier#34;with space&fatedier#34;` * `text/template`: `key = "with space"` Signed-off-by: Michael Hanselmann <public@hansmi.ch>
fatedier
approved these changes
Feb 7, 2025
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Feb 7, 2025
* https://github.com/fatedier/frp: Use text/template instead of html/template for config pre-processing (fatedier#4656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit c95311d added support for multiple config formats in addition to pre-processing using Go's built-in templating system. The
html/templatepackage is equivalent totext/template, except that the former automatically escapes characters for inclusion in HTML.Configurations aren't plain text, but they're also certainly no HTML. The difference between the packages is noticeable when using
printf "%q"for quoting of strings. An example from the included unittest:html/template:key = "with space"text/template:key = "with space"