Refactor FRP for Library Use and Update samber/lo Dependency to Latest Version #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- go.mod: Language not supported
Comments skipped due to low confidence (1)
pkg/nathole/controller.go:375
- Ensure that the case where
isLastisfalseis covered by tests.
if !isLast {
fatedier
approved these changes
Dec 2, 2024
github-actions bot
added a commit
to aiastia-dockerhub/frp
that referenced
this pull request
Dec 2, 2024
* https://github.com/fatedier/frp: samber lo version up (fatedier#4569)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
This PR refactors FRP to improve its usability as a library and updates the samber/lo dependency to the latest version. Key changes include:
Addresses Issue #4568 where FRP could not compile with the latest samber/lo.
close #4568