Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to manage default cert for custom TLS configurations #555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jenskueper
Copy link

This PR allows to manage the default certificate for custom TLS configuration. This is relevant for PlatformTLS.

@kpfleming
Copy link
Contributor

After some internal discussion it's going to be slightly challenging to accept this PR. While the code for the API endpoint is fine, the tests are not, because they will fail unless they are run using a user account that has one of the (limited) products enabled which support this field.

I think we'll need to have a separate set of test fixtures and test cases, which are skipped unless an environment variable named TEST_TLS_DEFAULT_CERTFICATE is set.

CC @Integralist

@Integralist
Copy link
Collaborator

The tests are run initially against the live API and those responses are saved into fixture files.

If the fixtures don't need updating any time soon then maybe it's fine. But yes, upgrading will require someone with access to this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants