📝 Clarify description of in-memory SQLite database in docs/tutorial/create-db-and-table.md
#601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to fix the CI here #602, but ultimately failed because poetry-version-plugin isn't working anymore. |
|
Yeah, I didn't see this. I since then got #602 to work and unblock CI . I assume tiangolo is currently quite busy with the pedantic V2 migration for FastAPI |
|
I confused two PRs, sorry! Reopening this. |
tiangolo
changed the title
tiangolo
changed the title
docs/tutorial/create-db-and-table.md
|
Great, thank you! 🚀 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to make the docs more clear by avoiding confusion about the in-memory url for sqlite.
Why:
I was quite confused because I didn't notice the difference between the sqlite urls with a filename and without a filename, using only two "//". Also, I first thought the in-memory database would be provided by SQLAlchemy, but only the url format is determined by SQLAlchemy.