Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in documentation from relationship attribute and all manipulation of back populate #579

Closed

Conversation

AdamMusa
Copy link

@AdamMusa AdamMusa commented Apr 5, 2023

I notice a few typo in documentation,so i decided to fix it .
I detected these errors because we did not take into consideration the key concept of sqlmodel concerning the back populate
Here is the key concept

That tells SQLModel that if something changes in this model, it should change that attribute in the other model, and it will work even before committing with the session (that would force a refresh of the data).

Here is the comparison considering the key concept of sqlmodel .
Here is some images after considering the key concept

after_0_relationship

after_01_relationship
after_back_relationship_0
after_back_relationship_001

![after_back_relationship_01](https://user-images.githubusercontent
after_back_relationship_002
.com/37194177/230231651-6a8c8f2d-5fee-476a-b7d6-225d8eacc153.png)
after_define_relationship_001
after_define_relationship_002

after_read_relationship_001
after_read_relationship_002
after_read_relationship_003
after_read_relationship_004

after_read_relationship_004

Here is some images before considering the key concept

before_0_relationship
before_back_relationship_01
before_back_relationship_001
before_back_relationship_002
before_define_relationship_001
before_define_relationship_002
before_read_relationship_001
before_read_relationship_002
before_read_relationship_003
before_read_relationship_004

before_01_relationship
before_back_relationship_0

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

📝 Docs preview for commit 3f5683c at: https://642e022017a6b01f2da4bb7f--sqlmodel.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

📝 Docs preview for commit 37bf39f at: https://642e09644dc21223dcf1b60a--sqlmodel.netlify.app

@tiangolo tiangolo added the docs Improvements or additions to documentation label Oct 22, 2023
@github-actions
Copy link

📝 Docs preview for commit 7f356e1 at: https://52913fa7.sqlmodel.pages.dev

@tiangolo
Copy link
Member

Thanks for the interest! That section refers to the updates in the Python objects. The database will be updated, but the objects are the ones that might not have all the updated data always... you can see the tests failing.

Given that, I'll pass on this one, but thanks for the effort. ☕

@tiangolo tiangolo closed this Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants